don't use new and delete

src/Game.cpp

@@ -1,3 +1,4 @@
+#include <mutex>
 #include <thread>
 #include <functional>
 #include "GameRenderer.hpp"
@@ -7,48 +8,47 @@
 
 using namespace std::literals::chrono_literals;
 
-Game::~Game()
-{
-    for (const Arrow *arrow : arrows) {
-        delete arrow;
-    }
-}
-
 void Game::update(std::stop_token stop_token)
 {
     while (!stop_token.stop_requested()) {
-        game_mutex.lock();
+        {
+            auto lock = std::lock_guard(game_mutex);
 
-        player.update();
+            ticks++;
 
-        for (Arrow *arrow : arrows) {
-            arrow->update();
+            player.update();
+
+            for (auto& arrow : arrows) {
+                arrow.update();
+            }
+
+            for (auto& zombo : zombos) {
+                zombo.update(player.x, player.y);
+            }
+
+            if (ticks % 1000 == 0) {
+                zombos.push_back(Zombo(&renderer, 20.0, 20.0));  // doesn't work :((((
+            }
+
+            renderer.redraw();
+
+            map.check_bounds(player.x, player.y);
         }
 
-        for (Zombo *zombo : zombos) {
-            zombo->update(player.x, player.y); // doesn't work :((((
-        }
-
-        renderer.redraw();
-
-        map.check_bounds(player.x, player.y);
-
-        game_mutex.unlock();
-
         std::this_thread::sleep_for(16666us);
     }
 }
 
 void Game::draw()
 {
-    const std::lock_guard lock(game_mutex);
+    std::lock_guard lock(game_mutex);
 
     renderer.clear_screen(0x80, 0x40, 0xFF, 0xFF);
 
     map.draw(player.x, player.y);
 
-    for (const Arrow *arrow : arrows) {
-        arrow->draw(player.x, player.y);
+    for (const auto& arrow : arrows) {
+        arrow.  draw(player.x, player.y);
     }
 
     player.draw();
@@ -58,61 +58,65 @@ void Game::draw()
 
 void Game::run()
 {
-    update_thread = std::jthread(std::bind_front(&Game::update, this));
+    auto update_thread = std::jthread(std::bind_front(&Game::update, this));
 
     while (true) {
         SDL_Event e;
         SDL_WaitEvent(&e);
 
-        if (e.type == SDL_QUIT) {
-            break;
-        }
+        {
+            auto lock = std::lock_guard(game_mutex);
 
-        if (e.type == SDL_KEYDOWN) {
-            switch (e.key.keysym.sym) {
-                case SDLK_RIGHT:
-                case SDLK_d:
-                    player.x_vel = player.speed;
-                    break;
-                case SDLK_LEFT:
-                case SDLK_a:
-                    player.x_vel = -player.speed;
-                    break;
-                case SDLK_DOWN:
-                case SDLK_s:
-                    player.y_vel = player.speed;
-                    break;
-                case SDLK_UP:
-                case SDLK_w:
-                    player.y_vel = -player.speed;
-                    break;
+            if (e.type == SDL_QUIT) {
+                break;
             }
-        }
 
-        if (e.type == SDL_KEYUP) {
-            switch (e.key.keysym.sym) {
-                case SDLK_RIGHT:
-                case SDLK_d:
-                case SDLK_LEFT:
-                case SDLK_a:
-                    player.x_vel = 0;
-                    break;
-                case SDLK_DOWN:
-                case SDLK_s:
-                case SDLK_UP:
-                case SDLK_w:
-                    player.y_vel = 0;
-                    break;
+            if (e.type == SDL_KEYDOWN) {
+                switch (e.key.keysym.sym) {
+                    case SDLK_RIGHT:
+                    case SDLK_d:
+                        player.x_vel = player.speed;
+                        break;
+                    case SDLK_LEFT:
+                    case SDLK_a:
+                        player.x_vel = -player.speed;
+                        break;
+                    case SDLK_DOWN:
+                    case SDLK_s:
+                        player.y_vel = player.speed;
+                        break;
+                    case SDLK_UP:
+                    case SDLK_w:
+                        player.y_vel = -player.speed;
+                        break;
+                }
             }
-        }
 
-        if (e.type == SDL_MOUSEBUTTONDOWN && e.button.button == 1) {
-            arrows.push_back(new Arrow(&renderer, player.x, player.y, player.angle));
-        }
+            if (e.type == SDL_KEYUP) {
+                switch (e.key.keysym.sym) {
+                    case SDLK_RIGHT:
+                    case SDLK_d:
+                    case SDLK_LEFT:
+                    case SDLK_a:
+                        player.x_vel = 0;
+                        break;
+                    case SDLK_DOWN:
+                    case SDLK_s:
+                    case SDLK_UP:
+                    case SDLK_w:
+                        player.y_vel = 0;
+                        break;
+                }
+            }
 
-        int mouse_x, mouse_y;
-        SDL_GetMouseState(&mouse_x, &mouse_y);
-        player.angle = std::atan2(mouse_y - renderer.screen_height / 2, mouse_x - renderer.screen_width / 2);
+            if (e.type == SDL_MOUSEBUTTONDOWN && e.button.button == 1) {
+                arrows.push_back(Arrow(&renderer, player.x, player.y, player.angle));
+            }
+
+            int mouse_x, mouse_y;
+            SDL_GetMouseState(&mouse_x, &mouse_y);
+            player.angle = std::atan2(mouse_y - renderer.screen_height / 2, mouse_x - renderer.screen_width / 2);
+        }
 
         draw();
     }

src/Game.hpp

@@ -1,7 +1,6 @@
 #ifndef GAME_HPP
 #define GAME_HPP
 
-#include <thread>
 #include <vector>
 #include <mutex>
 #include "Arrow.hpp"
@@ -16,10 +15,9 @@ private:
     GameRenderer renderer;
     Player player;
     Map map;
-    std::vector<Arrow*> arrows;
-    std::vector<Zombo*> zombos;
+    std::vector<Arrow> arrows;
+    std::vector<Zombo> zombos;
 
-    std::jthread update_thread;
     std::mutex game_mutex;
     unsigned int ticks = 0;
 
@@ -28,8 +26,6 @@ private:
 public:
     Game() : renderer("Zombo Shooter", 800, 450), player(&renderer), map(&renderer, 40) {}
 
-    ~Game();
-
     void run();
 
     void draw();